Various network topology examples. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/basic/setup_test.go
iwasaki-kenta
suggested changes
Jun 27, 2018
There was a problem hiding this comment.
Please follow the structure/code/comment style for the basic example: https://github.com/perlin-network/noise/tree/master/examples/basic
iwasaki-kenta
changed the title
# Conflicts: # examples/basic/setup_test.go
…the server is ready.
# Conflicts: # network/network.go
|
Converted the test into an example, can take a look. |
|
|
…topology-ring # Conflicts: # examples/topologies/topologies_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup networks for:
TODO:
1. fully connected with 5 nodes fails on broadcast2. mesh setup times out in discovery3. can look into taking out the time.sleeps() and use channels to speed this up (not blocking this PR)4. can clean up how ports are allocated, currently no way gracefully shutdown the server (not blocking this PR)