Clean up failure detection code

PBuild/Result.pm

@@ -25,21 +25,20 @@ use strict;
 use PBuild::Util;
 
 my @code_order = qw{broken succeeded failed unresolvable blocked scheduled waiting building excluded disabled locked};
-my @code_failures = qw{broken failed unresolvable};
+my %code_failures = map {$_ => 1} qw{broken failed unresolvable};
 
 sub print_result {
   my ($opts, $builddir) = @_;
   my $r = PBuild::Util::retrieve("$builddir/.pbuild/_result");
   die("pbuild has not run yet for $builddir\n") unless $r;
   my %codefilter = map {$_ => 1} @{$opts->{'result-code'} || []};
   my %pkgfilter = map {$_ => 1} @{$opts->{'result-pkg'} || []};
-  my %buildfailfilter = map{$_ => 1} @code_failures;
   my $found_failures = 0;
   my %codes_seen;
   for my $pkg (sort keys %$r) {
     next if %pkgfilter && !$pkgfilter{$pkg};
     my $code = $r->{$pkg}->{'code'} || 'unknown';
-    $found_failures = 1 if ($buildfailfilter{$code});
+    $found_failures = 1 if $code_failures{$code};
     next if %codefilter && !$codefilter{'all'} && !$codefilter{$code};
     push @{$codes_seen{$code}}, $pkg;
   }