Skip to content

Commit

Permalink
QTlsBackendOpenSSL: Make ensureLibraryLoaded() private
Browse files Browse the repository at this point in the history
This method is not used outside of the class right now.
This is also an initialization method that may not be
called recursively. Making it private hopefully makes
it harder to make this mistake in the future.

Task-number: QTBUG-103559
Change-Id: I8e1113e442e815320108b79bbd7b41bd28a66840
Reviewed-by: Mårten Nordheim <[email protected]>
  • Loading branch information
eugmes committed Sep 5, 2022
1 parent 8932eee commit 0206283
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/plugins/tls/openssl/qtlsbackend_openssl_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,14 @@ class QTlsBackendOpenSSL final : public QTlsBackend
static void logAndClearErrorQueue();
static void clearErrorQueue();

static bool ensureLibraryLoaded();
// Index used in SSL_get_ex_data to get the matching TlsCryptographerOpenSSL:
static bool s_loadedCiphersAndCerts;
static int s_indexForSSLExtraData;

static QString msgErrorsDuringHandshake();
static QSslCipher qt_OpenSSL_cipher_to_QSslCipher(const SSL_CIPHER *cipher);
private:

static bool ensureLibraryLoaded();
QString backendName() const override;
bool isValid() const override;
long tlsLibraryVersionNumber() const override;
Expand Down

0 comments on commit 0206283

Please sign in to comment.