[REMOVAL] Deprecate defaultExtras on Text component and VH

The attribute is no longer supported on TYPO3 8.6+ and automatic migration is not possible. The attribute is deprecated and will be removed in the next major version.
pfaffenrodt · Jul 31, 2017 · ed4bc00 · ed4bc00
1 parent 00c3809
commit ed4bc00
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 47 deletions.
diff --git a/Classes/Form/Field/Text.php b/Classes/Form/Field/Text.php
@@ -9,6 +9,7 @@
  */
 
 use FluidTYPO3\Flux\Form\FieldInterface;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * Text
@@ -94,6 +95,7 @@ public function getColumns()
      */
     public function setDefaultExtras($defaultExtras)
     {
+        GeneralUtility::logDeprecatedFunction();
         $this->defaultExtras = $defaultExtras;
         return $this;
     }
@@ -103,6 +105,7 @@ public function setDefaultExtras($defaultExtras)
      */
     public function getDefaultExtras()
     {
+        GeneralUtility::logDeprecatedFunction();
         return $this->defaultExtras;
     }
 

diff --git a/Classes/ViewHelpers/Field/TextViewHelper.php b/Classes/ViewHelpers/Field/TextViewHelper.php
@@ -9,6 +9,7 @@
  */
 
 use FluidTYPO3\Flux\Form\Field\Text;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
 
 /**
@@ -36,7 +37,7 @@ public function initializeArguments()
         $this->registerArgument(
             'defaultExtras',
             'string',
-            'FlexForm-syntax "defaultExtras" definition, example: "richtext[*]:rte_transform[mode=ts_css]"',
+            'DEPRECATED, IGNORED - has no function on TYPO3 8.7+. FlexForm-syntax "defaultExtras" definition, example: "richtext[*]:rte_transform[mode=ts_css]"',
             false,
             ''
         );
@@ -74,12 +75,14 @@ public function initializeArguments()
      */
     public static function getComponent(RenderingContextInterface $renderingContext, array $arguments)
     {
+        if (isset($arguments['defaultExtras'])) {
+            GeneralUtility::logDeprecatedViewHelperAttribute('defaultExtras', $renderingContext);
+        }
         /** @var Text $text */
         $text = static::getPreparedComponent('Text', $renderingContext, $arguments);
         $text->setValidate($arguments['validate']);
         $text->setColumns($arguments['cols']);
         $text->setRows($arguments['rows']);
-        $text->setDefaultExtras($arguments['defaultExtras']);
         $text->setEnableRichText($arguments['enableRichText']);
         $text->setRenderType($arguments['renderType']);
         $text->setFormat($arguments['format']);

diff --git a/Tests/Unit/Form/Field/TextTest.php b/Tests/Unit/Form/Field/TextTest.php
@@ -13,7 +13,6 @@
  */
 class TextTest extends InputTest
 {
-
     /**
      * @var array
      */
@@ -42,40 +41,4 @@ public function canChainSetterForEnableRichText()
         $this->assertSame($instance, $chained);
         $this->assertTrue($instance->getEnableRichText());
     }
-
-    /**
-     * @test
-     */
-    public function canChainSetterForDefaultExtras()
-    {
-        /** @var Text $instance */
-        $instance = $this->createInstance();
-        $chained = $instance->setDefaultExtras('void');
-        $this->assertSame($instance, $chained);
-        $this->assertSame('void', $instance->getDefaultExtras());
-    }
-
-    /**
-     * @test
-     */
-    public function canBuildConfigurationWithoutDefaultExtrasWithEnableRichText()
-    {
-        /** @var Text $instance */
-        $instance = $this->createInstance();
-        $instance->setDefaultExtras(null)->setEnableRichText(true);
-        $result = $this->performTestBuild($instance);
-        $this->assertArrayHasKey('defaultExtras', $result['config']);
-    }
-
-    /**
-     * @test
-     */
-    public function canBuildConfigurationWithDefaultExtras()
-    {
-        /** @var Text $instance */
-        $instance = $this->createInstance();
-        $instance->setDefaultExtras('richtext[*]');
-        $result = $this->performTestBuild($instance);
-        $this->assertNotEmpty($result['defaultExtras']);
-    }
 }
diff --git a/ext_localconf.php b/ext_localconf.php
@@ -49,14 +49,6 @@
 		$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/class.db_list_extra.inc']['getTable']['flux'] = \FluidTYPO3\Flux\Hooks\RecordListGetTableHookSubscriber::class;
 	}
 
-	\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTypoScript($_EXTKEY, 'setup', '
-		plugin.tx_flux.settings {
-			flexform {
-				rteDefaults = richtext:rte_transform[flag=rte_enabled|mode=ts_css]
-			}
-		}
-	');
-
 	if (TRUE === class_exists(\FluidTYPO3\Flux\Core::class)) {
 
 		// native Outlets, replaceable by short name in subsequent registerOutlet() calls by adding second argument (string, name of type)