Skip to content

Commit

Permalink
target/arm: Migrate MPU_RNR register state for M profile cores
Browse files Browse the repository at this point in the history
The PMSAv7 region number register is migrated for R profile
cores using the cpreg scheme, but M profile doesn't use
cpregs, and so we weren't migrating the MPU_RNR register state
at all. Fix that by adding a migration subsection for the
M profile case.

Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-id: [email protected]
  • Loading branch information
pm215 committed Jul 31, 2017
1 parent 69ceea6 commit f1a4694
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions target/arm/machine.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,29 @@ static const VMStateDescription vmstate_pmsav7 = {
}
};

static bool pmsav7_rnr_needed(void *opaque)
{
ARMCPU *cpu = opaque;
CPUARMState *env = &cpu->env;

/* For R profile cores pmsav7.rnr is migrated via the cpreg
* "RGNR" definition in helper.h. For M profile we have to
* migrate it separately.
*/
return arm_feature(env, ARM_FEATURE_M);
}

static const VMStateDescription vmstate_pmsav7_rnr = {
.name = "cpu/pmsav7-rnr",
.version_id = 1,
.minimum_version_id = 1,
.needed = pmsav7_rnr_needed,
.fields = (VMStateField[]) {
VMSTATE_UINT32(env.pmsav7.rnr, ARMCPU),
VMSTATE_END_OF_LIST()
}
};

static int get_cpsr(QEMUFile *f, void *opaque, size_t size,
VMStateField *field)
{
Expand Down Expand Up @@ -377,6 +400,11 @@ const VMStateDescription vmstate_arm_cpu = {
&vmstate_iwmmxt,
&vmstate_m,
&vmstate_thumb2ee,
/* pmsav7_rnr must come before pmsav7 so that we have the
* region number before we test it in the VMSTATE_VALIDATE
* in vmstate_pmsav7.
*/
&vmstate_pmsav7_rnr,
&vmstate_pmsav7,
NULL
}
Expand Down

0 comments on commit f1a4694

Please sign in to comment.