Make sure DOM components work in JSDOM

pgherveou · Oct 15, 2013 · 087c2af · 087c2af
1 parent b0645bd
commit 087c2af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/dom/components/ReactDOMInput.js b/src/dom/components/ReactDOMInput.js
@@ -103,7 +103,9 @@ var ReactDOMInput = ReactCompositeComponent.createClass({
 
     var value = this.getValue();
     if (value != null) {
-      DOMPropertyOperations.setValueForProperty(rootNode, 'value', value);
+      // Cast `value` to a string to ensure the value is set correctly. While
+      // browsers typically do this as necessary, jsdom doesn't.
+      DOMPropertyOperations.setValueForProperty(rootNode, 'value', '' + value);
     }
   },
 

diff --git a/src/dom/components/ReactDOMTextarea.js b/src/dom/components/ReactDOMTextarea.js
@@ -113,7 +113,9 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({
   componentDidUpdate: function(prevProps, prevState, rootNode) {
     var value = this.getValue();
     if (value != null) {
-      DOMPropertyOperations.setValueForProperty(rootNode, 'value', value);
+      // Cast `value` to a string to ensure the value is set correctly. While
+      // browsers typically do this as necessary, jsdom doesn't.
+      DOMPropertyOperations.setValueForProperty(rootNode, 'value', '' + value);
     }
   },