drivers: entropy: stm32: Move irq_lock at init

Perform clock check inside irq_lock in order to exit cleanly if failing. Signed-off-by: Erwan Gouriou <[email protected]>
phan-uy-vu · Nov 15, 2023 · 321c5e8 · 321c5e8
1 parent 2deea4e
commit 321c5e8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/entropy/entropy_stm32.c b/drivers/entropy/entropy_stm32.c
@@ -235,6 +235,8 @@ static int random_byte_get(void)
 	unsigned int key;
 	RNG_TypeDef *rng = entropy_stm32_rng_data.rng;
 
+	key = irq_lock();
+
 	if (IS_ENABLED(CONFIG_ENTROPY_STM32_CLK_CHECK) && !k_is_pre_kernel()) {
 		/* CECS bit signals that a clock configuration issue is detected,
 		 * which may lead to generation of non truly random data.
@@ -244,8 +246,6 @@ static int random_byte_get(void)
 			 "\tSee ref man and update target clock configuration.");
 	}
 
-	key = irq_lock();
-
 	if (LL_RNG_IsActiveFlag_SEIS(rng) && (recover_seed_error(rng) < 0)) {
 		retval = -EIO;
 		goto out;