Skip to content

Commit

Permalink
tests: bsim: Bluetooth: BAP Broadcast data validation
Browse files Browse the repository at this point in the history 
Add validation of sending and receiving dummy data.
Previously, due to a bug, we actually never sent any data
and still passed the test.

Signed-off-by: Emil Gydesen <[email protected]>
  • Loading branch information
@Thalley @carlescufi
Thalley authored and carlescufi committed Oct 20, 2023
1 parent 9c47eb9 commit ab60f5e
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 26 deletions.
42 changes: 39 additions & 3 deletions tests/bsim/bluetooth/audio/src/bap_broadcast_sink_test.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ static struct bt_le_scan_recv_info broadcaster_info;
static bt_addr_le_t broadcaster_addr;
static struct bt_le_per_adv_sync *pa_sync;
static uint32_t broadcaster_broadcast_id;
static struct bt_bap_stream broadcast_sink_streams[CONFIG_BT_BAP_BROADCAST_SNK_STREAM_COUNT];
static struct broadcast_sink_stream {
struct bt_bap_stream stream;
struct bt_iso_recv_info last_info;
size_t rx_cnt;
} broadcast_sink_streams[CONFIG_BT_BAP_BROADCAST_SNK_STREAM_COUNT];
static struct bt_bap_stream *streams[ARRAY_SIZE(broadcast_sink_streams)];

static const struct bt_audio_codec_cap codec_cap = BT_AUDIO_CODEC_CAP_LC3(
Expand Down Expand Up @@ -201,7 +205,39 @@ static void recv_cb(struct bt_bap_stream *stream,
const struct bt_iso_recv_info *info,
struct net_buf *buf)
{
SET_FLAG(flag_received);
struct broadcast_sink_stream *sink_stream =
CONTAINER_OF(stream, struct broadcast_sink_stream, stream);

if (sink_stream->rx_cnt > 0U && info->ts == sink_stream->last_info.ts) {
FAIL("Duplicated timestamp received: %u\n", sink_stream->last_info.ts);
return;
}

if (sink_stream->rx_cnt > 0U && info->seq_num == sink_stream->last_info.seq_num) {
FAIL("Duplicated PSN received: %u\n", sink_stream->last_info.seq_num);
return;
}

if (info->flags & BT_ISO_FLAGS_ERROR) {
FAIL("ISO receive error\n");
return;
}

if (info->flags & BT_ISO_FLAGS_LOST) {
FAIL("ISO receive lost\n");
return;
}

if (memcmp(buf->data, mock_iso_data, buf->len) == 0) {
sink_stream->rx_cnt++;

if (sink_stream->rx_cnt >= MIN_SEND_COUNT) {
/* We set the flag is just one stream has received the expected */
SET_FLAG(flag_received);
}
} else {
FAIL("Unexpected data received");
}
}

static struct bt_bap_stream_ops stream_ops = {
Expand Down Expand Up @@ -249,7 +285,7 @@ static int init(void)
UNSET_FLAG(pa_synced);

for (size_t i = 0U; i < ARRAY_SIZE(streams); i++) {
streams[i] = &broadcast_sink_streams[i];
streams[i] = &broadcast_sink_streams[i].stream;
bt_bap_stream_cb_register(streams[i], &stream_ops);
}

Expand Down
40 changes: 17 additions & 23 deletions tests/bsim/bluetooth/audio/src/bap_broadcast_source_test.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ NET_BUF_POOL_FIXED_DEFINE(tx_pool,
CONFIG_BT_CONN_TX_USER_DATA_SIZE, NULL);

extern enum bst_result_t bst_result;
static volatile size_t sent_count;
static struct bt_bap_stream broadcast_source_streams[CONFIG_BT_BAP_BROADCAST_SRC_STREAM_COUNT];
static struct bt_bap_stream *streams[ARRAY_SIZE(broadcast_source_streams)];
static struct bt_bap_lc3_preset preset_16_2_1 = BT_BAP_LC3_BROADCAST_PRESET_16_2_1(
BT_AUDIO_LOCATION_FRONT_LEFT, BT_AUDIO_CONTEXT_TYPE_UNSPECIFIED);
static struct bt_bap_lc3_preset preset_16_2_2 = BT_BAP_LC3_BROADCAST_PRESET_16_2_2(
BT_AUDIO_LOCATION_FRONT_LEFT, BT_AUDIO_CONTEXT_TYPE_UNSPECIFIED);
CREATE_FLAG(flag_stopping);

static K_SEM_DEFINE(sem_started, 0U, ARRAY_SIZE(streams));
static K_SEM_DEFINE(sem_stopped, 0U, ARRAY_SIZE(streams));
static K_SEM_DEFINE(sem_started, 0U, ARRAY_SIZE(broadcast_source_streams));
static K_SEM_DEFINE(sem_stopped, 0U, ARRAY_SIZE(broadcast_source_streams));

static void started_cb(struct bt_bap_stream *stream)
{
Expand All @@ -53,8 +53,6 @@ static void stopped_cb(struct bt_bap_stream *stream, uint8_t reason)

static void sent_cb(struct bt_bap_stream *stream)
{
static uint8_t mock_data[CONFIG_BT_ISO_TX_MTU];
static bool mock_data_initialized;
static uint16_t seq_num;
struct net_buf *buf;
int ret;
Expand All @@ -63,14 +61,6 @@ static void sent_cb(struct bt_bap_stream *stream)
return;
}

if (!mock_data_initialized) {
for (size_t i = 0U; i < ARRAY_SIZE(mock_data); i++) {
/* Initialize mock data */
mock_data[i] = (uint8_t)i;
}
mock_data_initialized = true;
}

buf = net_buf_alloc(&tx_pool, K_FOREVER);
if (buf == NULL) {
printk("Could not allocate buffer when sending on %p\n",
Expand All @@ -80,15 +70,16 @@ static void sent_cb(struct bt_bap_stream *stream)

net_buf_reserve(buf, BT_ISO_CHAN_SEND_RESERVE);
/* Use preset_16_2_1 as that is the config we end up using */
net_buf_add_mem(buf, mock_data, preset_16_2_1.qos.sdu);
ret = bt_bap_stream_send(stream, buf, seq_num++,
BT_ISO_TIMESTAMP_NONE);
net_buf_add_mem(buf, mock_iso_data, preset_16_2_1.qos.sdu);
ret = bt_bap_stream_send(stream, buf, seq_num++, BT_ISO_TIMESTAMP_NONE);
if (ret < 0) {
/* This will end broadcasting on this stream. */
printk("Unable to broadcast data on %p: %d\n", stream, ret);
net_buf_unref(buf);
FAIL("Unable to broadcast data on %p: %d\n", stream, ret);
return;
}

sent_count++;
}

static struct bt_bap_stream_ops stream_ops = {
Expand Down Expand Up @@ -351,7 +342,7 @@ static void test_broadcast_source_start(struct bt_bap_broadcast_source *source,

/* Wait for all to be started */
printk("Waiting for streams to be started\n");
for (size_t i = 0U; i < ARRAY_SIZE(streams); i++) {
for (size_t i = 0U; i < ARRAY_SIZE(broadcast_source_streams); i++) {
k_sem_take(&sem_started, K_FOREVER);
}
}
Expand All @@ -371,7 +362,7 @@ static void test_broadcast_source_stop(struct bt_bap_broadcast_source *source)

/* Wait for all to be stopped */
printk("Waiting for streams to be stopped\n");
for (size_t i = 0U; i < ARRAY_SIZE(streams); i++) {
for (size_t i = 0U; i < ARRAY_SIZE(broadcast_source_streams); i++) {
k_sem_take(&sem_stopped, K_FOREVER);
}
}
Expand Down Expand Up @@ -447,14 +438,17 @@ static void test_main(void)
test_broadcast_source_start(source, adv);

/* Initialize sending */
for (size_t i = 0U; i < ARRAY_SIZE(streams); i++) {
printk("Sending data\n");
for (size_t i = 0U; i < ARRAY_SIZE(broadcast_source_streams); i++) {
for (unsigned int j = 0U; j < BROADCAST_ENQUEUE_COUNT; j++) {
sent_cb(streams[i]);
sent_cb(&broadcast_source_streams[i]);
}
}

/* Keeping running for a little while */
k_sleep(K_SECONDS(15));
/* Keep sending until we reach the minimum expected */
while (sent_count < (MIN_SEND_COUNT * ARRAY_SIZE(broadcast_source_streams))) {
k_sleep(K_MSEC(100));
}

/* Update metadata while streaming */
printk("Updating metadata\n");
Expand Down
21 changes: 21 additions & 0 deletions tests/bsim/bluetooth/audio/src/common.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@
#include <zephyr/bluetooth/uuid.h>
#include <zephyr/bluetooth/gatt.h>

static const uint8_t mock_iso_data[] = {
0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, 0x18, 0x19, 0x1a, 0x1b, 0x1c, 0x1d, 0x1e,
0x1f, 0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27, 0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d,
0x2e, 0x2f, 0x30, 0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39, 0x3a, 0x3b, 0x3c,
0x3d, 0x3e, 0x3f, 0x40, 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, 0x49, 0x4a, 0x4b,
0x4c, 0x4d, 0x4e, 0x4f, 0x50, 0x51, 0x52, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59, 0x5a,
0x5b, 0x5c, 0x5d, 0x5e, 0x5f, 0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x68, 0x69,
0x6a, 0x6b, 0x6c, 0x6d, 0x6e, 0x6f, 0x70, 0x71, 0x72, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78,
0x79, 0x7a, 0x7b, 0x7c, 0x7d, 0x7e, 0x7f, 0x80, 0x81, 0x82, 0x83, 0x84, 0x85, 0x86, 0x87,
0x88, 0x89, 0x8a, 0x8b, 0x8c, 0x8d, 0x8e, 0x8f, 0x90, 0x91, 0x92, 0x93, 0x94, 0x95, 0x96,
0x97, 0x98, 0x99, 0x9a, 0x9b, 0x9c, 0x9d, 0x9e, 0x9f, 0xa0, 0xa1, 0xa2, 0xa3, 0xa4, 0xa5,
0xa6, 0xa7, 0xa8, 0xa9, 0xaa, 0xab, 0xac, 0xad, 0xae, 0xaf, 0xb0, 0xb1, 0xb2, 0xb3, 0xb4,
0xb5, 0xb6, 0xb7, 0xb8, 0xb9, 0xba, 0xbb, 0xbc, 0xbd, 0xbe, 0xbf, 0xc0, 0xc1, 0xc2, 0xc3,
0xc4, 0xc5, 0xc6, 0xc7, 0xc8, 0xc9, 0xca, 0xcb, 0xcc, 0xcd, 0xce, 0xcf, 0xd0, 0xd1, 0xd2,
0xd3, 0xd4, 0xd5, 0xd6, 0xd7, 0xd8, 0xd9, 0xda, 0xdb, 0xdc, 0xdd, 0xde, 0xdf, 0xe0, 0xe1,
0xe2, 0xe3, 0xe4, 0xe5, 0xe6, 0xe7, 0xe8, 0xe9, 0xea, 0xeb, 0xec, 0xed, 0xee, 0xef, 0xf0,
0xf1, 0xf2, 0xf3, 0xf4, 0xf5, 0xf6, 0xf7, 0xf8, 0xf9, 0xfa, 0xfb, 0xfc, 0xfd, 0xfe, 0xff,
};

#define MIN_SEND_COUNT 100
#define WAIT_SECONDS 60 /* seconds */
#define WAIT_TIME (WAIT_SECONDS * USEC_PER_SEC) /* microseconds*/

Expand Down

0 comments on commit ab60f5e

Please sign in to comment.