mgmt: ec_host_cmd: verify a command before passing it to handler

Verify validity of a received command before passing it to the general handler. It allows performing some actions, right after receiving the command. The context switch is not needed. Such feature may be needed for overloaded system, where instant reboot is required. Signed-off-by: Dawid Niedzwiecki <[email protected]>
phan-uy-vu · Jul 12, 2023 · b6a3254 · b6a3254
1 parent 1b6d6fb
commit b6a3254
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/include/zephyr/mgmt/ec_host_cmd/ec_host_cmd.h b/include/zephyr/mgmt/ec_host_cmd/ec_host_cmd.h
@@ -29,6 +29,8 @@ struct ec_host_cmd {
 	 * when data in rx_ctx are ready. The handler takes rx_ready to read data in rx_ctx.
 	 */
 	struct k_sem rx_ready;
+	/** Status of the rx data checked in the ec_host_cmd_send_received function. */
+	enum ec_host_cmd_status rx_status;
 #ifdef CONFIG_EC_HOST_CMD_DEDICATED_THREAD
 	struct k_thread thread;
 #endif /* CONFIG_EC_HOST_CMD_DEDICATED_THREAD */

diff --git a/subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c b/subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c
@@ -242,6 +242,9 @@ int ec_host_cmd_send_response(enum ec_host_cmd_status status,
 void ec_host_cmd_rx_notify(void)
 {
 	struct ec_host_cmd *hc = &ec_host_cmd;
+	struct ec_host_cmd_rx_ctx *rx = &hc->rx_ctx;
+
+	hc->rx_status = verify_rx(rx);
 
 	k_sem_give(&hc->rx_ready);
 }
@@ -303,9 +306,12 @@ FUNC_NORETURN static void ec_host_cmd_thread(void *hc_handle, void *arg2, void *
 		k_sem_take(&hc->rx_ready, K_FOREVER);
 
 		ec_host_cmd_log_request(rx->buf);
-		status = verify_rx(rx);
-		if (status != EC_HOST_CMD_SUCCESS) {
-			ec_host_cmd_send_response(status, &args);
+
+		/* Check status of the rx data, that has been verified in
+		 * ec_host_cmd_send_received.
+		 */
+		if (hc->rx_status != EC_HOST_CMD_SUCCESS) {
+			ec_host_cmd_send_response(hc->rx_status, &args);
 			continue;
 		}