Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffer overflow in zero terminator code for debugging #170

Conversation

robzed
Copy link
Contributor

@robzed robzed commented Dec 23, 2024

Simple change to avoid segmentation fault caused by zero terminator being written in wrong place, especially bad on lines longer than half the TIB size.

Fixes #174

@philburk philburk merged commit 43d49ef into philburk:master Dec 26, 2024
3 checks passed
philburk added a commit that referenced this pull request Dec 27, 2024
Mainly because of the fix for the crash in #170
that could occur if an include file contained long lines.
@robzed robzed deleted the pforth_SDL/Fixes-philburk/pforth#169-zero-terminator-bug-causes-TIB-overflows branch December 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buffer overflow in readLineFromStream() can cause a crash
2 participants