Long name support #182
Open
Long name support #182
+54
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philburk
requested changes
Dec 31, 2024
| /* Most Forth word names are short - so 31 characters should be enough. | ||
| * However if you are integrating with other systems - for example libSDL | ||
| * some names are longer than 31 characters. This provides up to 63 characters | ||
| * for a word names. |
There was a problem hiding this comment.
Suggested change
| * for a word names. | |
| * for word names. |
There was a problem hiding this comment.
I could also be convinced to just make long names the default. Hmm.
| * Long term this can become the default since there is no storage penalty | ||
| * when not using them. | ||
| */ | ||
| #define LONG_NAME_SUPPORT |
There was a problem hiding this comment.
Let's make this like the other compile time switches defined at:
https://www.softsynth.com/pforth/pf_ref.php#Compiler-Options
Let's rename it to PF_SUPPORT_LONG_NAMES
and leave it undefined for now.
Maybe we can test it on/off in GitHub Actions.
| @@ -63,10 +80,19 @@ | |||
| #define FTRUE (-1) | |||
| #define BLANK (' ') | |||
|
|
|||
| #define FLAG_PRECEDENCE (0x80) | |||
| /* #define FLAG_PRECEDENCE (0x80) */ | |||
There was a problem hiding this comment.
Please add:
/* The IMMEDIATE flag is known as the "precedence bit" on some other Forth systems. */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds long word name support.
Questions:
Currently this is gated by a #define
LONG_NAME_SUPPORT- currently enabled, but it can be build without to support old dictionaries with a build - however, maybe we should remove this and only support long names?I added two Primitive Token IDS - which expose the FLAG_SMUDGE and MASK_NAME_SIZE ... these allow the Forth files to not have magic numbers unrelated to the Forth core... I can understand why we didn't do this in the past (size), but I think the dependency is strong between the two - and the Forth code is clearer for it. However it is a design decision - so should we do this or revert this part?
I left FLAG_PRECEDENCE commented out - maybe this should be removed.
Name to long warnings/errors to be raised as a separate PR.