Skip to content

Commit

Permalink
[dapp-kit] theme the UI components 🎨 (MystenLabs#13994)
Browse files Browse the repository at this point in the history
## Description 

This PR builds on the theme definition PR to fix up our styling and to
actually leverage the theme definitions. I'd say this is looking _pretty
good_ - I think really we need to test out some themes / try porting
this into SuiFrens, and customizing the connect button / dropdown to
make sure we're providing the right level of customization. There might
also be a little more design polish work as well for things like the
"What is a wallet button" on mobile.

Follow-ups to get this a bit better shape since I'm out on PTO the rest
of the week:
- There's one FIXME to align the back and X icons because they don't
align on mobile
- The "What is a Wallet" button could use some love on the design side
- There's a CI failure for PostCSS even though I didn't change anything
and rebased on main
- We might need to add some more theme variables for things like the
border between the left & right modal panels


https://github.com/MystenLabs/sui/assets/7453188/a5da40d6-3d1f-45e8-9348-3c9ecb41d7e6

## Test Plan 
- Manual testing

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes

---------

Co-authored-by: Jordan Gensler <[email protected]>
  • Loading branch information
williamrobertson13 and Jordan-Mysten authored Oct 4, 2023
1 parent f569b13 commit 1227ee1
Show file tree
Hide file tree
Showing 40 changed files with 655 additions and 172 deletions.
5 changes: 5 additions & 0 deletions .changeset/fresh-trainers-lay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@mysten/dapp-kit': minor
---

Theme UI components based on provided theme and add design polish
2 changes: 1 addition & 1 deletion .github/actions/ts-e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
ref: ${{ inputs.ref }}
# Disabled for now as it makes test runs take longer
# - uses: bmwill/rust-cache@v1 # Fork of 'Swatinem/rust-cache' which allows caching additional paths
- uses: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd # pin@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changesets-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
uses: actions/checkout@7dd9e2a3dc350cf687eb1b2a4fadfee8c8e49675 # pin@v3
with:
fetch-depth: 0
- uses: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd # pin@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8
- name: Install Nodejs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changesets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
token: ${{ steps.generate_token.outputs.token }}
fetch-depth: 0
- uses: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd # pin@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8
- name: Install Nodejs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@7dd9e2a3dc350cf687eb1b2a4fadfee8c8e49675 # pin@v3
# Disabled for now as it makes test runs take longer
# - uses: bmwill/rust-cache@v1 # Fork of 'Swatinem/rust-cache' which allows caching additional paths
- uses: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd # pin@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8
- run: cargo build --bin sui-test-validator --bin sui --profile dev
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: pnpm/action-setup@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8
- name: Install Nodejs
Expand All @@ -31,7 +31,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 2
- uses: pnpm/action-setup@v2.2.4
- uses: pnpm/action-setup@v2.4.0
with:
version: 8
- name: Install Nodejs
Expand Down
2 changes: 1 addition & 1 deletion apps/explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"react-router-dom": "^6.14.2",
"throttle-debounce": "^5.0.0",
"topojson-client": "^3.1.0",
"vite-plugin-rewrite-all": "^1.0.1",
"zod": "^3.21.4"
},
"devDependencies": {
Expand Down Expand Up @@ -111,6 +110,7 @@
"tsconfig-paths": "^4.2.0",
"typescript": "^5.1.6",
"vite": "^4.4.4",
"vite-plugin-rewrite-all": "^1.0.1",
"vite-plugin-svgr": "^3.2.0",
"vitest": "^0.33.0"
},
Expand Down
2 changes: 1 addition & 1 deletion dapps/kiosk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
"dependencies": {
"@headlessui/react": "^1.7.15",
"@headlessui/tailwindcss": "^0.1.3",
"@mysten/kiosk": "workspace:*",
"@mysten/sui.js": "workspace:*",
"@mysten/wallet-kit": "workspace:*",
Expand All @@ -29,6 +28,7 @@
"react-router-dom": "^6.14.2"
},
"devDependencies": {
"@headlessui/tailwindcss": "^0.1.3",
"@types/react": "^18.2.15",
"@types/react-dom": "^18.2.7",
"@vitejs/plugin-react": "^4.0.3",
Expand Down
8 changes: 4 additions & 4 deletions dapps/multisig-toolkit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"@radix-ui/react-popover": "^1.0.6",
"@radix-ui/react-slot": "^1.0.2",
"@radix-ui/react-tabs": "^1.0.4",
"@tailwindcss/forms": "^0.5.4",
"@tanstack/react-query": "^4.29.25",
"class-variance-authority": "^0.7.0",
"clsx": "^2.0.0",
Expand All @@ -36,20 +35,21 @@
"react-hook-form": "^7.45.2",
"react-router-dom": "^6.14.2",
"tailwind-merge": "^1.14.0",
"tailwindcss-animate": "^1.0.6",
"vite-tsconfig-paths": "^4.2.0",
"zod": "^3.21.4"
},
"devDependencies": {
"@mysten/sui.js": "workspace:*",
"@mysten/wallet-kit": "workspace:*",
"@tailwindcss/forms": "^0.5.4",
"@types/react": "^18.2.15",
"@types/react-dom": "^18.2.7",
"@vitejs/plugin-react": "^4.0.3",
"autoprefixer": "^10.4.14",
"postcss": "^8.4.26",
"tailwindcss": "^3.3.3",
"tailwindcss-animate": "^1.0.6",
"typescript": "^5.1.6",
"vite": "^4.4.4"
"vite": "^4.4.4",
"vite-tsconfig-paths": "^4.2.0"
}
}
Loading

0 comments on commit 1227ee1

Please sign in to comment.