Skip to content

Commit

Permalink
revert client-request-header (MystenLabs#20161)
Browse files Browse the repository at this point in the history
## Description 

Describe the changes or additions included in this PR.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
hayes-mysten authored Nov 4, 2024
1 parent c538507 commit 69ef100
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/nervous-ears-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@mysten/sui': patch
---

revert adding client-request-method header
1 change: 0 additions & 1 deletion sdk/typescript/src/client/http-transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export class SuiHTTPTransport implements SuiTransport {
'Client-Sdk-Type': 'typescript',
'Client-Sdk-Version': PACKAGE_VERSION,
'Client-Target-Api-Version': TARGETED_RPC_VERSION,
'Client-Request-Method': input.method,
...this.#options.rpc?.headers,
},
body: JSON.stringify({
Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/test/unit/client/http-transport.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('SuiHTTPTransport', () => {
'Client-Sdk-Type': 'typescript',
'Client-Sdk-Version': PACKAGE_VERSION,
'Client-Target-Api-Version': TARGETED_RPC_VERSION,
'Client-Request-Method': 'getAllBalances',
// 'Client-Request-Method': 'getAllBalances',
},
method: 'POST',
});
Expand Down

0 comments on commit 69ef100

Please sign in to comment.