Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link DOM living spec #193

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Link DOM living spec #193

merged 1 commit into from
Dec 2, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Dec 1, 2024

No description provided.

Comment on lines 79 to 82
<!ENTITY url.spec.dom.living.node "https://dom.spec.whatwg.org/#interface-node">
<!ENTITY url.spec.dom.living.attr "https://dom.spec.whatwg.org/#interface-attr">
<!ENTITY url.spec.dom.living.characterdata "https://dom.spec.whatwg.org/#interface-characterdata">
<!ENTITY url.spec.dom.living.comment "https://dom.spec.whatwg.org/#interface-comment">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a "base" entity which just has the URL? And have the others ones use that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm maybe, we don't really do that for the rest though 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do it a lot in language-snippets but not here indeed...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tomorrow problem...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 907ad1d into php:master Dec 2, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants