-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip package #6
Pip package #6
Conversation
The GUI part has been removed entirely, a new pyproject file created and all the data files moved to allow installation with the package.
The use of LICENSE looks to be more common than COPYING so lets use that.
While we are updating the pipeline, use latest actions from the marketplace and test with all currently supported versions of python.
We are using functionality from importlib.resource that arrived in version 3.10. As support for 3.9 will soon(ish) stop, lets not do anything special.
Changing the project to a package was his idea and he did a lot of the leg work in PR #5 so should be in the authors list.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
To align with AME, always refer to NUBASE in all capital letters.
I noticed that the the atomic mass in the AME mass files are actually given as |
Also I found that For a small dataset like this, I do not suppose there is any performance benefit of doing it one way or the other. But since you mentioned the possibility of archiving this and creating a new project in #8, maybe we can try |
Good find! I think a new package is going to be created so might as well start using that function. Not sure why the initial value is ignored when reading the atomic mass. I'll fix that in the new package. |
I wrote some code with |
@php1ic I added the code for AME (1993 - 2020) in commit 19c024c in the |
Thanks for looking into the usage of I'm going to move all development to the new package and not merge this PR, leaving the repo in the pre-package state. Hopefully see you over there 👍 |
As suggested by @e-eight in both #4 and #5 let's make this project into to a pip installable package.
As this is a major change, I will take the opportunity to drop the plotting part of the package. If people need it, it can be added back in, but I believe focussing on the parsing of the data files should be the core of the packages functionality.