Allow method tag return type to be by reference #166
Conversation
Like normal methods the method tag might return by reference. This fix introduces the support of reference return types. However in a real world implementation it not very likely one would ever mix reference return types with none reference return types. If even possible using php __call.
| @@ -340,6 +342,16 @@ private function parseMethodTagValue(TokenIterator $tokens): Ast\PhpDoc\MethodTa | |||
| $returnType = $isStatic ? new Ast\Type\IdentifierTypeNode('static') : null; | |||
| $methodName = $returnTypeOrMethodName->name; | |||
| $isStatic = false; | |||
| } elseif ( | |||
| $returnTypeOrMethodName instanceof Ast\Type\IntersectionTypeNode | |||
There was a problem hiding this comment.
No, that's a horrible hack 😂
There was a problem hiding this comment.
I'm sorry for this 😊
There was a problem hiding this comment.
How to solve this in a better way? I think this would require a change in the type parser as it is now to greedy.
|
@ondrejmirtes before I invest more time to improve this PR, would you merge this feature or is it not a valid case for phpstan? It would force me to find another solution on my side, but that's somehow okish. |
|
@jaapio Hi, I'm pretty sceptical about this. I don't think that PHPStan would use this information in any way (that a method returns by reference). How do you think it'd enhance the analysis? Also, what about just reading whether |
|
I think from an analysis point of view, you could still read In case of phpstan the return type being a |
|
I’m sorry, that doesn’t sound that exciting, unless you have a bug that’d be prevented with this in mind 😊 |
ondrejmirtes
force-pushed
the
1.9.x
branch
2 times, most recently
from
d25945f to
57f6787
Compare
Like normal methods the method tag might return by reference. This fix introduces the support of reference return types. However in a real world implementation it not very likely one would ever mix reference return types with none reference return types. If even possible using php __call.
fixes #158