Skip to content

Commit

Permalink
MDL-71494 mod_feedback: final removal of deprecated constructor param.
Browse files Browse the repository at this point in the history
  • Loading branch information
paulholden committed Sep 5, 2023
1 parent 206c3a6 commit 56cd63a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
7 changes: 1 addition & 6 deletions mod/feedback/classes/output/summary.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,10 @@ class summary implements renderable, templatable {
/**
* Constructor.
*
* @todo MDL-71494 Final deprecation of the $extradetails parameter in Moodle 4.3
* @param mod_feedback_structure $feedbackstructure
* @param int $mygroupid currently selected group
* @param bool|null $extradetails Deprecated
*/
public function __construct($feedbackstructure, $mygroupid = false, $extradetails = null) {
if (isset($extradetails)) {
debugging('The $extradetails parameter is deprecated.', DEBUG_DEVELOPER);
}
public function __construct($feedbackstructure, $mygroupid = false) {
$this->feedbackstructure = $feedbackstructure;
$this->mygroupid = $mygroupid;
}
Expand Down
7 changes: 7 additions & 0 deletions mod/feedback/upgrade.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
This file describes API changes in /mod/feedback/*
Information provided here is intended especially for developers.

=== 4.3 ===

* The `$extradetails` parameter of the `\mod_feedback\output\summary` class constructor has been removed

=== 4.2 ===
* The external methods get_items() and get_page_items() now only return the items when the user can access the feedback; if the
user can't see them, a warning message will be returned, with the reasons.
Expand Down

0 comments on commit 56cd63a

Please sign in to comment.