forked from facebook/hermes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make OSS libhermes ABI compatible with RN
Summary: We removed a method that RN currently uses, which means that Hermes 0.2.x can not be used with RN <=0.60.5. See facebook#109 This diff adds a dummy passthrough method for linking compatibility. Reviewed By: mhorowitz Differential Revision: D17351288 fbshipit-source-id: 7d98af7065064dd47f66dba9ca82ac1192dff133
1 parent
da4e30b
commit 5b6c59e
Showing
2 changed files
with
26 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/* | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the LICENSE | ||
* file in the root directory of this source tree. | ||
*/ | ||
#include "hermes_tracing.h" | ||
#include "llvm/Support/ErrorHandling.h" | ||
|
||
namespace facebook { | ||
namespace hermes { | ||
|
||
// This function is here for ABI linking compatibility. | ||
std::unique_ptr<jsi::Runtime> makeTracingHermesRuntime( | ||
std::unique_ptr<HermesRuntime> hermesRuntime, | ||
const ::hermes::vm::RuntimeConfig &runtimeConfig) { | ||
if (!runtimeConfig.getTraceEnvironmentInteractions()) { | ||
return hermesRuntime; | ||
} | ||
llvm_unreachable("Invoked compat makeTracingHermesRuntime!"); | ||
} | ||
|
||
} // namespace hermes | ||
} // namespace facebook |