Add Sync framework #202
Merged
Add Sync framework #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
===========================================
+ Coverage 34.64% 60.36% +25.71%
===========================================
Files 292 310 +18
Lines 7291 7654 +363
===========================================
+ Hits 2526 4620 +2094
+ Misses 4765 3034 -1731
Continue to review full report at Codecov.
|
pietrocaselani
force-pushed
the
sync-reducer
branch
from
5b797da to
4f76bc8
Compare
added 25 commits
December 31, 2019 18:07
* Only one entry point, the function `setupSyncModule(trakt:)` * To ensure the statement above, the tests run in DEBUG mode without importing the framework using `@testable` * I am using snapshot testing because the JSON is big, there is a lot of data about episodes, seasons and the tv show * I will probrably use the snapshot testing library for screenshot tests... excited for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to create a separated framework to handle the synchronization between the APIs (Trakt, TMDB, TVDB) and the persistence layer of the app.