Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'skipCoverage' option to build library config #215

Merged
merged 2 commits into from
Oct 23, 2024
Merged

add 'skipCoverage' option to build library config #215

merged 2 commits into from
Oct 23, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Oct 23, 2024 •
edited
Loading

This allows for packages to skip test coverage as part of the Github workflow checks by setting skipCoverage: yes in .buildlibrary

tscheypidi
tscheypidi requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good, but you still need to add it to the documentation in buildLibrary (there is a list of config settings for .buildlibrary)

@fbenke-pik fbenke-pik merged commit ae95d01 into pik-piam:master Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-sauer pascal-sauer pascal-sauer approved these changes

@tscheypidi tscheypidi tscheypidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbenke-pik @tscheypidi @pascal-sauer