Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clearity: Remove unnecessary inversion of logical #217

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

robinhasse
Copy link
Contributor

I was irritated by the inverted interpretation of allowLinterWarnings inside verifyLinter so I changed it. This should improve readability and have no effect of the correct functioning of the function.

Copy link
Contributor

@pascal-sauer pascal-sauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please undo the default value change, the rest looks good 👍

R/check.R Outdated Show resolved Hide resolved
R/check.R Show resolved Hide resolved
@pascal-sauer pascal-sauer merged commit 9c61ab4 into pik-piam:master Nov 29, 2024
4 checks passed
@robinhasse robinhasse deleted the allowLinterSwitch branch November 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants