Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18100 Add password check to isEqualTo method of User class #18141

Open
wants to merge 3 commits into
base: 12.x
Choose a base branch
from

Conversation

scrummer
Copy link
Contributor

Changes in this pull request

Resolves #18100

Additional info

This PR adds an additional password check to make sure that other sessions get terminated, when the user is being loaded from the session and meanwhile the password has been changed from another session.

Copy link

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Enrich Pimcore\Security\User\User::isEqualTo with password check
2 participants