Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in speaker biography help text. #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martey
Copy link
Contributor

@martey martey commented Apr 24, 2017

This has been broken since 36ab6d5.

@jhrr
Copy link

jhrr commented Aug 18, 2017

Thanks very much for the fix. While we're at it, I think a multi-line string and some formatting changes like the following would make things a bit more readable and manageable here:

biography = models.TextField(
    blank=True,
    help_text=_(
        """A little bit about you. Edit using <a
        href='http://warpedvisions.org/projects/markdown-cheat-sheet/'
        target='_blank'>Markdown</a>."""
    ),
    verbose_name=_("Biography")
)

@jhrr
Copy link

jhrr commented Aug 18, 2017

Or if not the triple quotes then at least something like this?

biography = models.TextField(
    blank=True,
    help_text=_(
        "A little bit about you. Edit using"
        "<a href='http://warpedvisions.org/projects/markdown-cheat-sheet/'target='_blank'>"
        "Markdown</a>."
    ),
    verbose_name=_("Biography")
)

@martey martey force-pushed the fix-speaker-markdown-link branch from 82a6a2b to 77ec2b7 Compare August 19, 2017 23:49
@martey
Copy link
Contributor Author

martey commented Aug 19, 2017

I've updated the formatting and changed to the link to use HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants