Add EmbedResponse type, regenerate core for 2024-10
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onse type to abstract the generated type
austin-denoble
changed the base branch from
main
to
release-candidate/2024-10
haruska
approved these changes
Oct 22, 2024
austin-denoble
added a commit
that referenced
this pull request
Oct 23, 2024
## Problem There have been a few small PRs that have gone into the `apis` repo that we need to regenerate code for: - pinecone-io/apis#175 - pinecone-io/apis#171 We're also returning the generated `EmbeddingsList` type for the `Embed` method rather than a custom type like we're doing elsewhere. ## Solution - Add new `EmbedResponse`, and `Embedding` types and return from `Embed`. Add doc comments. - Regenerate core SDK code from `2024-10` ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Make sure CI is successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There have been a few small PRs that have gone into the
apisrepo that we need to regenerate code for:We're also returning the generated
EmbeddingsListtype for theEmbedmethod rather than a custom type like we're doing elsewhere.Solution
EmbedResponse, andEmbeddingtypes and return fromEmbed. Add doc comments.2024-10Type of Change
Test Plan
Make sure CI is successful.