Make sure logintime string can never overflow (Coverity CID 1164485).

pinotree · Jan 26, 2014 · 7d6e368 · 7d6e368
1 parent ae7c73e
commit 7d6e368
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/last.c b/src/last.c
@@ -396,7 +396,8 @@ int list(struct utmp *p, time_t t, int what)
 	 *	Calculate times
 	 */
 	tmp = (time_t)p->ut_time;
-	strcpy(logintime, ctime(&tmp));
+	strncpy(logintime, ctime(&tmp), sizeof(logintime));
+	logintime[sizeof(logintime)-1] = 0; /* enforce null termination */
 	if (fulltime)
 		sprintf(logouttime, "- %s", ctime(&t));
 	else {