Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Store Types #202

Closed
wants to merge 1 commit into from
Closed

Typo in Store Types #202

wants to merge 1 commit into from

Conversation

kmwarter
Copy link

@kmwarter kmwarter commented Jan 20, 2020

Description

RootState type is added twice. I think that you meant to include Store in the types here.

Related issues:

-NA

Checklist

  • I have read CONTRIBUTING.md
  • I have edited README_SOURCE.md (NOT README.md)
  • I have run CI script locally npm run ci-check to generate an updated README.md
  • I have linked all related issues above
  • I have rebased my branch

It does not make sense to me why you would use the RootState type twice and I don't see Store used here. I think that you meant to include Store in the types here.
@kmwarter kmwarter closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant