Remove unneeded arguments checks

piranna · Jul 6, 2018 · 112af1e · 112af1e
1 parent 6623a2e
commit 112af1e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 24 deletions.
diff --git a/lib/BannerPlugin.js b/lib/BannerPlugin.js
@@ -23,13 +23,7 @@ const wrapComment = str => {
 };
 
 class BannerPlugin {
-	constructor(options) {
-		if (arguments.length > 1) {
-			throw new Error(
-				"BannerPlugin only takes one argument (pass an options object)"
-			);
-		}
-
+	constructor(options = {}) {
 		validateOptions(schema, options, "Banner Plugin");
 
 		if (typeof options === "string" || typeof options === "function") {
@@ -38,7 +32,7 @@ class BannerPlugin {
 			};
 		}
 
-		this.options = options || {};
+		this.options = options;
 
 		if (typeof options.banner === "function") {
 			const getBanner = this.options.banner;

diff --git a/lib/EvalSourceMapDevToolPlugin.js b/lib/EvalSourceMapDevToolPlugin.js
@@ -7,22 +7,25 @@
 const EvalSourceMapDevToolModuleTemplatePlugin = require("./EvalSourceMapDevToolModuleTemplatePlugin");
 const SourceMapDevToolModuleOptionsPlugin = require("./SourceMapDevToolModuleOptionsPlugin");
 
+/** @typedef {import("./Compiler")} Compiler */
+
 class EvalSourceMapDevToolPlugin {
-	constructor(options) {
-		if (arguments.length > 1) {
-			throw new Error(
-				"EvalSourceMapDevToolPlugin only takes one argument (pass an options object)"
-			);
-		}
+	/**
+	 * @param {TODO} options Options object
+	 */
+	constructor(options = {}) {
 		if (typeof options === "string") {
 			options = {
 				append: options
 			};
 		}
-		if (!options) options = {};
 		this.options = options;
 	}
 
+	/**
+	 * @param {Compiler} compiler Webpack Compiler
+	 * @returns {void}
+	 */
 	apply(compiler) {
 		const options = this.options;
 		compiler.hooks.compilation.tap(

diff --git a/lib/SourceMapDevToolPlugin.js b/lib/SourceMapDevToolPlugin.js
@@ -52,16 +52,9 @@ const getTaskForFile = (file, chunk, options, compilation) => {
 };
 
 class SourceMapDevToolPlugin {
-	constructor(options) {
-		if (arguments.length > 1) {
-			throw new Error(
-				"SourceMapDevToolPlugin only takes one argument (pass an options object)"
-			);
-		}
-
-		validateOptions(schema, options || {}, "SourceMap DevTool Plugin");
+	constructor(options = {}) {
+		validateOptions(schema, options, "SourceMap DevTool Plugin");
 
-		if (!options) options = {};
 		this.sourceMapFilename = options.filename;
 		this.sourceMappingURLComment =
 			options.append === false