Add types to SplitChunksPlugin

piranna · Dec 10, 2018 · 5f26040 · 5f26040
1 parent 760b1da
commit 5f26040
Show file tree

Hide file tree

Showing 2 changed files with 377 additions and 185 deletions.
diff --git a/lib/ids/IdHelpers.js b/lib/ids/IdHelpers.js
@@ -13,6 +13,11 @@ const { makePathsRelative } = require("../util/identifier");
 /** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../Module")} Module */
 
+/**
+ * @param {string} str string to hash
+ * @param {number} len max length of the hash
+ * @returns {string} hash
+ */
 const getHash = (str, len) => {
 	const hash = createHash("md4");
 	hash.update(str);
@@ -37,13 +42,21 @@ const getHashNumber = (str, len) => {
 		.join("");
 };
 
+/**
+ * @param {string} str the string
+ * @returns {string} string prefixed by an underscore if it is a number
+ */
 const avoidNumber = str => {
 	if (str === +str + "") {
 		return `_${str}`;
 	}
 	return str;
 };
 
+/**
+ * @param {string} request the request
+ * @returns {string} id representation
+ */
 const requestToId = request => {
 	return request
 		.replace(/^(\.\.?\/)+/, "")