Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AWS-CDK V1 support; Bumps minor dependency versions #51

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pistazie
Copy link
Owner

@pistazie pistazie commented Aug 4, 2024

No description provided.

@swiesmann
Copy link

swiesmann commented Sep 14, 2024

I noticed there is another way to get a unique ID via

const uid: string = Names.uniqueId(myConstruct);
(from the aws docs https://docs.aws.amazon.com/cdk/v2/guide/identifiers.html)

But since it expects a construct we would have basically do CDK backwards: parsing the CloudFormation JSON into constructs somehow. 🙈

So copying the makeUniqueId function over makes more sense. We would have to check for license conflicts as the official cdk is under Apache V2 while cdk-dia is MIT licensed.

@robdmoore
Copy link

Hi, Is there an eta on this one landing? Love this project, but needing to take dependency on v1 cdk is becoming increasingly difficult as it gets more and more out of date and brings in vulnerable dependencies to the project. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants