Merge pull request protofire#291 from protofire/pragma-experimental-c…

…ompiler-rule Check name of pragma for compiler-rule
pizza-777 · May 26, 2021 · b4ac341 · b4ac341
2 parents 15a964c + 19a1b89
commit b4ac341
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/security/compiler-version.js b/lib/rules/security/compiler-version.js
@@ -48,7 +48,10 @@ class CompilerVersionChecker extends BaseChecker {
   }
 
   PragmaDirective(node) {
-    if (!semver.satisfies(semver.minVersion(node.value), this.requirement)) {
+    if (
+      node.name === 'solidity' &&
+      !semver.satisfies(semver.minVersion(node.value), this.requirement)
+    ) {
       this.warn(
         node,
         `Compiler version ${node.value} does not satisfy the ${this.requirement} semver requirement`

diff --git a/test/rules/security/compiler-version.js b/test/rules/security/compiler-version.js
@@ -187,4 +187,19 @@ describe('Linter - compiler-version', () => {
 
     assert.equal(report.errorCount, 0)
   })
+
+  it(`should not report compiler version error with correct pragma and pragma experimental`, () => {
+    const report = linter.processStr(
+      `pragma solidity ^0.7.4;
+       pragma experimental ABIEncoderV2;
+       
+       contract Main {
+       }`,
+      {
+        rules: { 'compiler-version': ['error', '^0.7.4'] }
+      }
+    )
+
+    assert.equal(report.errorCount, 0)
+  })
 })