removing changes

pkshr · Mar 20, 2020 · b291ec4 · b291ec4
1 parent 518daaa
commit b291ec4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/deployer/handlers.go b/deployer/handlers.go
@@ -4,11 +4,10 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/coinbase/step/errors"
-	"github.com/coinbase/step/utils/to"
-
 	"github.com/coinbase/odin/aws"
 	"github.com/coinbase/odin/deployer/models"
+	"github.com/coinbase/step/errors"
+	"github.com/coinbase/step/utils/to"
 )
 
 // DeployHandler function type
@@ -91,7 +90,7 @@ func ValidateResources(awsc aws.Clients) DeployHandler {
 			}
 		}
 
-		release.UpdateWithResources(resources, awsc.ALBClient(release.AwsRegion, release.AwsAccountID, assumedRole))
+		release.UpdateWithResources(resources)
 
 		return release, nil
 	}

diff --git a/deployer/models/release_resources.go b/deployer/models/release_resources.go
@@ -111,7 +111,7 @@ func (release *Release) ValidateResources(resources *ReleaseResources) error {
 }
 
 // UpdateWithResources returns
-func (release *Release) UpdateWithResources(resources *ReleaseResources, albc aws.ALBAPI) {
+func (release *Release) UpdateWithResources(resources *ReleaseResources) {
 	// Assign PreDesiredCapacity
 	// Assign ServiceResourceName
 

diff --git a/deployer/models/release_resources_test.go b/deployer/models/release_resources_test.go
@@ -43,7 +43,7 @@ func Test_Release_UpdateWithResources_Works(t *testing.T) {
 	sm, err := r.FetchResources(awsc.ASG, awsc.EC2, awsc.ELB, awsc.ALB, awsc.IAM, awsc.SNS)
 	assert.NoError(t, err)
 
-	r.UpdateWithResources(sm, awsc.ALB)
+	r.UpdateWithResources(sm)
 }
 
 func Test_Release_FetchResources_Stores_WaitForDetach(t *testing.T) {

diff --git a/deployer/models/service.go b/deployer/models/service.go
@@ -7,10 +7,6 @@ import (
 
 	"github.com/aws/aws-sdk-go/service/autoscaling"
 	"github.com/aws/aws-sdk-go/service/autoscaling/autoscalingiface"
-
-	"github.com/coinbase/step/utils/is"
-	"github.com/coinbase/step/utils/to"
-
 	"github.com/coinbase/odin/aws"
 	"github.com/coinbase/odin/aws/alb"
 	"github.com/coinbase/odin/aws/asg"
@@ -19,6 +15,8 @@ import (
 	"github.com/coinbase/odin/aws/lc"
 	"github.com/coinbase/odin/aws/pg"
 	"github.com/coinbase/odin/aws/sg"
+	"github.com/coinbase/step/utils/is"
+	"github.com/coinbase/step/utils/to"
 )
 
 // HealthReport is built to make log lines like: