Overhaul build system for proper subproject dependency wiring #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnttiMK
changed the title
|
I'd appreciate if Kotlin was not introduced since I'm not familiar with it. :) |
- Swagger is back - Added JVM forking to compile and tests to possibly improve build performance - Removed duplicate caffeine version field - Addressed some exclusions and relocations
This way Bukkit plugin.yml won't end up in Fabric JAR, etc.
AnttiMK
force-pushed
the
chore/build-improvements
branch
from
2097e15 to
973ba8d
Compare
|
Waiting for the PAL artifact so can run CI 🤞🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
/Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/html/Contributors.java/Plan/common/src/main/java/com/djrapitops/plan/settings/locale/LangCode.javaDescription
The biggest change this PR aims to achieve is to rip out the inherently binding and index-crippling shadowJar dependency declaration between modules, and instead use proper library configuration and dependency declaration by doing the necessary configuration changes in build files and PAL.
I'm also trying get rid of some deprecations, do lazy evaluation of stuff etc. modern Gradle things, and remove all configurations from the root project (especially "java-library"). Also looking to convert to kotlin since that seems to be the standard nowadays, but I might just CBA.
Done so far (some might be waiting for
git push)commonmoduletestFixturessource set to be consumed by platform modulestodo
options.release = 17(apparently tests use newer java than 11?? xD)tasks.register('testJar', Jar)actually needed?