Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board: yd-esp32-s3-N16R8 #1270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thijstriemstra
Copy link

@thijstriemstra thijstriemstra commented Jan 1, 2024

@valeros
Copy link
Member

valeros commented Jan 9, 2024

Hi @thijstriemstra, thanks for the PR. Any reason why you chose adafruit_feather_esp32s3 as the variant for this board? Are you sure the pinout is the same?

@thijstriemstra
Copy link
Author

Any reason why you chose adafruit_feather_esp32s3 as the variant for this board? Are you sure the pinout is the same?

I used the definition found here: https://github.com/bigtreetech/KNOMI/tree/firmware/buildroot/boards

And it worked for the board but if there's a better variant available, please let me know and I'll test.

@valeros
Copy link
Member

valeros commented Jan 9, 2024

And it worked for the board but if there's a better variant available, please let me know and I'll test.

I'm just concerned that the pinout may differ (e.g. LED_BUILTIN) so that even simple blink won't work. I'd prefer that the board manifest is created on the base of a generic devkit from Espressif (e.g esp32-s3-devkitc-1), but ideally, a proper variant implementation should be added to https://github.com/espressif/arduino-esp32.

@Bendikos
Copy link

Bendikos commented Jan 28, 2024

image
@valeros look,It's the equivalent of YD buying the core module, carving the board, and selling it.
I don't think it's necessary to add a new board model because the pins are the same, so you can modify the flash size,As shown in the following figure:

[env:esp32s3]
platform = espressif32
board = esp32-s3-devkitc-1
framework = arduino
; 指定为16MB的FLASH分区表
board_build.arduino.partitions = default_16MB.csv
; 指定FLASH和PSRAM的运行模式
board_build.arduino.memory_type = qio_opi
; 预定义宏启用PSRAM
build_flags = -DBOARD_HAS_PSRAM
; 指定FLASH容量为16MB
board_upload.flash_size = 16MB

Reference link: Reference link

@thijstriemstra
Copy link
Author

I'd prefer that the board manifest is created on the base of a generic devkit from Espressif

Agreed, I guess #1383 would be a better alternative for this board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants