Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Board Definition for Waveshare ESP32-S3 with 1.28 in Display #1332

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Create Board Definition for Waveshare ESP32-S3 with 1.28 in Display #1332

wants to merge 2 commits into from

Conversation

deisterhold
Copy link

@valeros
Copy link
Member

valeros commented Mar 16, 2024

Hi @deisterhold, thanks for the PR. It's highly desirable that a proper variant header file is added to this repo https://github.com/espressif/arduino-esp32 in the first place.

@deisterhold
Copy link
Author

@valeros created PR for new variant and updated in board definition.

@deisterhold
Copy link
Author

PR has been merged.

@valeros
Copy link
Member

valeros commented Mar 26, 2024

Thanks for pinging, the board will be added once a new stable release of Arduino core is published.

@scar027 scar027 mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
board request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deisterhold @valeros