make the apex domain error more visually important #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I took the language of the DNS from https://docs.platform.sh/domains/steps.html#2-configure-your-dns-provider |
chadwcarlson
approved these changes
Dec 16, 2024
|
Makes sense @hanoii. Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4285 . Thanks for merging but I was truly annoyed about this which ended up with a 30m downtime on the client end.
I think it's very important that's why I rather have it as a warning, and also make it very clear that removing the TXT is not an immediate fix, because until your API server doesn't see that the TXT was removed the error will still appear and you will not be able to add the apex domain to any project.
I can't emphasise enough that whatever protection this txt record relates to the apex domain should be handled differently.