Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subplots with layout grids #1110

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

michaelbabyn
Copy link
Contributor

resolves #1029 .

I updated the relevant examples in https://plot.ly/javascript/subplots/ as well as those in https://plot.ly/javascript/pie-charts/#pie-chart-subplots.

@michaelbabyn michaelbabyn requested a review from cldougl October 2, 2018 21:47
@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Oct 2, 2018
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
I'll make a follow up issue to add some similar examples in python and r :)

@@ -23,7 +21,7 @@
labels: ['US', 'China', 'European Union', 'Russian Federation', 'Brazil', 'India', 'Rest of World' ],
text: 'CO2',
textposition: 'inside',
domain: {x: [.52, 1]},
domain: {column: 1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 10, 2018
@michaelbabyn michaelbabyn merged commit ddfd23d into source-design-merge Oct 10, 2018
@michaelbabyn michaelbabyn deleted the subplots-with-layout-grids branch October 10, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include layout.grid in more subplot examples
2 participants