Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify that only values changed by event will be emitted by events #1127

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

michaelbabyn
Copy link
Contributor

resolves #873

@michaelbabyn michaelbabyn requested a review from cldougl October 11, 2018 14:14
@cldougl cldougl added the ReviewReady This PR is ready for review label Oct 23, 2018
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo fix then this is good to merge!
💃


For Cartesian (2D) plots, `plotly_relayout` emits the xaxis and yaxis ranges. For 3D plots, [`layout.scene.camera`](https://plot.ly/javascript/reference/#layout-scene-camera) data is emitted. See the full structures below:
For Cartesian (2D) plots, `plotly_relayout` emits the only the xaxis and yaxis ranges which were directly changed by the triggering event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 double the

emits the only the xaxis and yaxis ranges which were directly changed

@cldougl cldougl removed the ReviewReady This PR is ready for review label Oct 23, 2018
@michaelbabyn michaelbabyn merged commit 461c281 into source-design-merge Oct 23, 2018
@michaelbabyn michaelbabyn deleted the event_data_clarification branch October 23, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify what info shows up in restyle/relayout event data
2 participants