-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installing dependencies in node v22 #7381
base: master
Are you sure you want to change the base?
Conversation
thanks @chaigh-uk - I'll try to prioritize review in the next cycle. |
@@ -129,7 +129,7 @@ | |||
"browserify-transform-tools": "^1.7.0", | |||
"bubleify": "^2.0.0", | |||
"buffer": "^6.0.3", | |||
"canvas": "^2.11.2", | |||
"canvas": "^3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -148,7 +148,7 @@ | |||
"into-stream": "^6.0.0", | |||
"jasmine": "3.5.0", | |||
"jasmine-core": "3.5.0", | |||
"jsdom": "^24.1.1", | |||
"jsdom": "^26.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsdom v25
appears to improve security issues in regards to the "dangerously"
option used by tasks/util/plotly_node.mjs
This dependency bump from v24 to v26 seems good to me.
@chaigh-uk Thanks very much for the PR. You could fetch upstream/master and then add a test titled
plotly.js/.circleci/config.yml Line 410 in 40f2221
You also need to add your new plotly.js/.circleci/config.yml Line 553 in 40f2221
Thank you! |
Thanks for taking a look @archmoj - I've had a go at this in 46e0277 |
💯 🙏 Many thanks @chaigh-uk for the smart addition of node 22 tests. It is interesting to see node v22 tests appear to run faster. It would be great if someone else from @plotly/plotly_js also help approve this PR. On another note @chaigh-uk used a pattern in 46e0277 that simplified testing in different container versions. IMHO - It would be of interest to apply similar pattern in other places in plotly.js and plotly.py and dash tests to reduce/avoid duplicated CircleCI config code |
Fixes #7306
Bumps
canvas
to v3.1.0 andjsdom
to v26.0.0The key fix was in canvas and is detailed here