Enabled lint on Google (aquasecurity#874)

pmalkki · Aug 31, 2021 · 13261b5 · 13261b5
1 parent aabb629
commit 13261b5
Show file tree

Hide file tree

Showing 110 changed files with 272 additions and 296 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -20,7 +20,6 @@
         "helpers/google/functions.js",
         "helpers/oracle/functions.js",
         "plugins/github/",
-        "plugins/google/",
         "plugins/oracle/",
         "*.spec.js"
     ],

diff --git a/plugins/google/bigquery/datasetAllUsersPolicy.js b/plugins/google/bigquery/datasetAllUsersPolicy.js
@@ -78,4 +78,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/clb/clbCDNEnabled.js b/plugins/google/clb/clbCDNEnabled.js
@@ -69,4 +69,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/clb/clbHttpsOnly.js b/plugins/google/clb/clbHttpsOnly.js
@@ -47,7 +47,7 @@ module.exports = {
             });
 
             if (non_https_listener.length) {
-                msg = "The following Load Balancers are not HTTPS-only: ";
+                let msg = 'The following Load Balancers are not HTTPS-only: ';
                 helpers.addResult(
                     results, 2, msg + non_https_listener.join(', '), region, null);
             } else {
@@ -59,4 +59,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/clb/clbNoInstances.js b/plugins/google/clb/clbNoInstances.js
@@ -40,4 +40,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/compute/autoscaleEnabled.js b/plugins/google/compute/autoscaleEnabled.js
@@ -18,7 +18,7 @@ module.exports = {
         let instanceGroupsObj = helpers.addSource(cache, source,
             ['instanceGroups', 'aggregatedList', ['global']]);
 
-        if (!instanceGroupsObj) return callback(null, results, source)
+        if (!instanceGroupsObj) return callback(null, results, source);
 
         if (instanceGroupsObj.err || !instanceGroupsObj.data) {
             helpers.addResult(results, 3, 'Unable to query instance groups', 'global', null, null, instanceGroupsObj.err);
@@ -48,7 +48,7 @@ module.exports = {
         async.each(instanceGroups, function(instanceGroupsInLocation, rcb) {
             instanceGroupsInLocation.instanceGroups.forEach(instanceGroup => {
                 if (instanceGroup.name) {
-                    instanceGroupURLObj[instanceGroup.name] = instanceGroup
+                    instanceGroupURLObj[instanceGroup.name] = instanceGroup;
                 }
             });
 
@@ -72,8 +72,8 @@ module.exports = {
                                 nodePool.instanceGroupUrls.length) {
                                 nodePool.instanceGroupUrls.forEach(instanceGroupUrl => {
                                     var instanceGroupUrlName = instanceGroupUrl.split('/')[10];
-                                    if (instanceGroupURLObj.hasOwnProperty(instanceGroupUrlName)) {
-                                        delete instanceGroupURLObj[instanceGroupUrlName]
+                                    if (instanceGroupURLObj[instanceGroupUrlName]) {
+                                        delete instanceGroupURLObj[instanceGroupUrlName];
                                     }
                                 });
                             }
@@ -97,8 +97,8 @@ module.exports = {
                 async.each(autoscalers, function(autoscalersInLocation, lcb) {
                     autoscalersInLocation.autoscalers.forEach(autoscaler => {
                         if (autoscaler.name) {
-                            if (instanceGroupURLObj.hasOwnProperty(autoscaler.name)) {
-                                delete instanceGroupURLObj[autoscaler.name]
+                            if (instanceGroupURLObj[autoscaler.name]) {
+                                delete instanceGroupURLObj[autoscaler.name];
                             }
                         }
                     });

diff --git a/plugins/google/compute/csekEncryptionEnabled.js b/plugins/google/compute/csekEncryptionEnabled.js
@@ -73,9 +73,9 @@ module.exports = {
                         disk.diskEncryptionKey &&
                         Object.keys(disk.diskEncryptionKey) &&
                         Object.keys(disk.diskEncryptionKey).length) {
-                        goodDisks.push(disk.id)
+                        goodDisks.push(disk.id);
                     } else if (disk.creationTimestamp) {
-                        badDisks.push(disk.id)
+                        badDisks.push(disk.id);
                     }
                 });
 
@@ -87,7 +87,7 @@ module.exports = {
                         badDisks.forEach(disk=> {
                             let resource = helpers.createResourceName('disks', disk, project, 'zone', zone);
                             helpers.addResult(results, 2,
-                                `CSEK Encryption is disabled for disk`, region, resource);
+                                'CSEK Encryption is disabled for disk', region, resource);
                         });
                     }
                 }
@@ -99,7 +99,7 @@ module.exports = {
                         goodDisks.forEach(disk=> {
                             let resource = helpers.createResourceName('disks', disk, project, 'zone', zone);
                             helpers.addResult(results, 0,
-                                `CSEK Encryption is enabled for disk`, region, resource);
+                                'CSEK Encryption is enabled for disk', region, resource);
                         });
                     }
                 }

diff --git a/plugins/google/compute/instanceDesiredMachineTypes.js b/plugins/google/compute/instanceDesiredMachineTypes.js
@@ -17,7 +17,7 @@ module.exports = {
             default: ''
         },
     },
-    run: function (cache, settings, callback) {
+    run: function(cache, settings, callback) {
         var results = [];
         var source = {};
         var regions = helpers.regions();
@@ -34,7 +34,7 @@ module.exports = {
         async.each(regions.instances.compute, (region, rcb) => {
             var noInstances = [];
             var zones = regions.zones;
-            async.each(zones[region], function (zone, zcb) {
+            async.each(zones[region], function(zone, zcb) {
                 var instances = helpers.addSource(cache, source,
                     ['instances', 'compute', 'list', zone]);
 
@@ -61,13 +61,13 @@ module.exports = {
                     }
                 });
                 zcb();
-            }, function () {
+            }, function() {
                 if (noInstances.length) {
                     helpers.addResult(results, 0, `No instances found in following zones: ${noInstances.join(', ')}`, region);
                 }
                 rcb();
             });
-        }, function () {
+        }, function() {
             callback(null, results, source);
         });
     }

diff --git a/plugins/google/compute/instanceLeastPrivilege.js b/plugins/google/compute/instanceLeastPrivilege.js
@@ -63,7 +63,7 @@ module.exports = {
 
                     if (found) {
                         helpers.addResult(results, 2,
-                            `Instance Service account has full access` , region, resource);
+                            'Instance Service account has full access' , region, resource);
                     } else {
                         helpers.addResult(results, 0,
                             'Instance Service account follows least privilege' , region, resource);

diff --git a/plugins/google/compute/instanceMaxCount.js b/plugins/google/compute/instanceMaxCount.js
@@ -193,8 +193,8 @@ module.exports = {
 
 
         };
-        for (c in config) {
-            if (settings.hasOwnProperty(c)) {
+        for (let c in config) {
+            if (settings[c]) {
                 config[c] = settings[c];
             }
         }
@@ -235,7 +235,7 @@ module.exports = {
                     return zcb();
                 }
                 instances.data.forEach(instance => {
-                    if (instance.status && instance.status == "RUNNING") {
+                    if (instance.status && instance.status == 'RUNNING') {
                         instanceCountGlobal +=1;
                         instanceCount +=1;
                     }
@@ -272,18 +272,18 @@ module.exports = {
                 rcb();
             });
         }, function() {
-             // Print global results
-             var globalThreshold = config.instance_count_global_threshold;
-
-             if (instanceCountGlobal > globalThreshold) {
-                 helpers.addResult(results, 2,
-                     instanceCountGlobal + ' instances running in all regions, exceeding limit of: ' + globalThreshold, null, null, custom);
-             } else {
-                 helpers.addResult(results, 0,
-                     instanceCountGlobal + ' instances in the account are within the global expected count of: ' + globalThreshold, null, null, custom);
-             }
+            // Print global results
+            var globalThreshold = config.instance_count_global_threshold;
+
+            if (instanceCountGlobal > globalThreshold) {
+                helpers.addResult(results, 2,
+                    instanceCountGlobal + ' instances running in all regions, exceeding limit of: ' + globalThreshold, null, null, custom);
+            } else {
+                helpers.addResult(results, 0,
+                    instanceCountGlobal + ' instances in the account are within the global expected count of: ' + globalThreshold, null, null, custom);
+            }
 
-             callback(null, results, source); 
+            callback(null, results, source); 
         });
     }
 };
diff --git a/plugins/google/compute/instanceTemplateMachineTypes.js b/plugins/google/compute/instanceTemplateMachineTypes.js
@@ -17,7 +17,7 @@ module.exports = {
             default: ''
         },
     },
-    run: function (cache, settings, callback) {
+    run: function(cache, settings, callback) {
         var results = [];
         var source = {};
         var regions = helpers.regions();
@@ -33,7 +33,7 @@ module.exports = {
                 'Unable to query for projects: ' + helpers.addError(projects), 'global', null, null, (projects) ? projects.err : null);
             return callback(null, results, source);
         }
-        async.each(regions.instanceTemplates, function (region, rcb) {
+        async.each(regions.instanceTemplates, function(region, rcb) {
             let instanceTemplates = helpers.addSource(
                 cache, source, ['instanceTemplates', 'list', region]);
             if (!instanceTemplates) return rcb();
@@ -58,7 +58,7 @@ module.exports = {
                 }
             });
             rcb();
-        }, function () {
+        }, function() {
             callback(null, results, source);
         });
     }

diff --git a/plugins/google/compute/instancesMultiAz.js b/plugins/google/compute/instancesMultiAz.js
@@ -38,7 +38,7 @@ module.exports = {
             return callback(null, results, source);
         } else {
             var groupName = [];
-            async.each(instanceGroups.data, function (instanceGroup, icb) {
+            async.each(instanceGroups.data, function(instanceGroup, icb) {
                 if (instanceGroup.instanceGroups) {
                     instanceGroup.instanceGroups.forEach(group => {
                         if (group.region) {
@@ -47,10 +47,10 @@ module.exports = {
                     });
                 }
                 icb();
-            }, function () {
-                async.each(regions.instances.compute, function (location, loccb) {
+            }, function() {
+                async.each(regions.instances.compute, function(location, loccb) {
                     var noInstances = [];
-                    async.each(regions.zones[location], function (loc, lcb) {
+                    async.each(regions.zones[location], function(loc, lcb) {
                         let instances = helpers.addSource(
                             cache, source, ['instances', 'compute', 'list', loc]);
 
@@ -86,7 +86,7 @@ module.exports = {
                     }, function() {
                         if (noInstances.length) {
                             helpers.addResult(results, 0,
-                                `No instances found in following zones: ${noInstances.join(', ')}`, location)
+                                `No instances found in following zones: ${noInstances.join(', ')}`, location);
                         }
                         loccb();
                     });

diff --git a/plugins/google/compute/ipForwardingDisabled.js b/plugins/google/compute/ipForwardingDisabled.js
@@ -68,4 +68,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/compute/osLoginEnabled.js b/plugins/google/compute/osLoginEnabled.js
@@ -61,4 +61,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/cryptographickeys/keyProtectionLevel.js b/plugins/google/cryptographickeys/keyProtectionLevel.js
@@ -79,4 +79,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/cryptographickeys/keyRotation.js b/plugins/google/cryptographickeys/keyRotation.js
@@ -70,4 +70,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/dataflow/dataflowHangedJobs.js b/plugins/google/dataflow/dataflowHangedJobs.js
@@ -51,7 +51,7 @@ module.exports = {
 
                 if (job.currentState && !['JOB_STATE_RUNNING', 'JOB_STATE_DRAINING', 'JOB_STATE_CANCELLING'].includes(job.currentState.toUpperCase())) {
                     helpers.addResult(results, 0,
-                        `Dataflow job has completed`, region, resource);
+                        'Dataflow job has completed', region, resource);
                     return cb();
                 }
 
@@ -73,4 +73,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/dataflow/dataflowJobsEncryption.js b/plugins/google/dataflow/dataflowJobsEncryption.js
@@ -109,4 +109,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/deploymentmanager/deleteExpiredDeployments.js b/plugins/google/deploymentmanager/deleteExpiredDeployments.js
@@ -82,4 +82,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/dns/dnsSecEnabled.js b/plugins/google/dns/dnsSecEnabled.js
@@ -50,7 +50,7 @@ module.exports = {
                                 (managedZone.dnssecConfig.state &&
                                 managedZone.dnssecConfig.state !== 'on')))) {
                     helpers.addResult(results, 2,
-                        `The managed zone does not have DNS security enabled`, region, resource);
+                        'The managed zone does not have DNS security enabled', region, resource);
                 } else {
                     helpers.addResult(results, 0, 'The managed zone has DNS security enabled', region, resource);
                 }
@@ -62,4 +62,4 @@ module.exports = {
             callback(null, results, source);
         });
     }
-}
+};
diff --git a/plugins/google/iam/corporateEmailsOnly.js b/plugins/google/iam/corporateEmailsOnly.js
@@ -44,7 +44,7 @@ module.exports = {
                                     gmailUsers.push(member);
                                 }
                             }
-                        })
+                        });
                     }
                 });
             }

diff --git a/plugins/google/iam/kmsUserSeparation.js b/plugins/google/iam/kmsUserSeparation.js
@@ -47,25 +47,25 @@ module.exports = {
             var notSeparated = [];
             iamPolicy.bindings.forEach(roleBinding => {
                 if (roleBinding.role === 'roles/cloudkms.admin') {
-                    serviceAccountUsers = serviceAccountUsers.concat(roleBinding.members)
+                    serviceAccountUsers = serviceAccountUsers.concat(roleBinding.members);
                 }
             });
 
             iamPolicy.bindings.forEach(roleBinding => {
                 if (roleBinding.role === 'roles/cloudkms.cryptoKeyDecrypter' &&
                     roleBinding.members) {
                     notSeparated = roleBinding.members.filter(member => {
-                        return (serviceAccountUsers.indexOf(member) > -1)
+                        return (serviceAccountUsers.indexOf(member) > -1);
                     }).concat(notSeparated);
                 } else if (roleBinding.role === 'roles/cloudkms.cryptoKeyEncrypter' &&
                     roleBinding.members) {
                     notSeparated = roleBinding.members.filter(member => {
-                        return (serviceAccountUsers.indexOf(member) > -1)
+                        return (serviceAccountUsers.indexOf(member) > -1);
                     }).concat(notSeparated);
                 } else if (roleBinding.role === 'roles/cloudkms.cryptoKeyEncrypterDecrypter' &&
                     roleBinding.members) {
                     notSeparated = roleBinding.members.filter(member => {
-                        return (serviceAccountUsers.indexOf(member) > -1)
+                        return (serviceAccountUsers.indexOf(member) > -1);
                     }).concat(notSeparated);
                 }
             });
@@ -76,7 +76,7 @@ module.exports = {
                     let accountName = (account.includes(':')) ? account.split(':')[1] : account;
                     let resource = helpers.createResourceName('serviceAccounts', accountName, project);
                     helpers.addResult(results, 2,
-                        `Account has the KMS admin role and one or more CryptoKey roles`, region, resource);
+                        'Account has the KMS admin role and one or more CryptoKey roles', region, resource);
                 });
             } else {
                 helpers.addResult(results, 0, 'No accounts have a KMS admin role or a CryptoKey key role', region);
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,4 +78,4 @@ module.exports = { @@
                 callback(null, results, source);
             });
         }
-    }
+    };