[ISSUE apache#4551] modify the logic of time-consumption statistics (a…

…pache#4822)
pmupkin · Apr 11, 2024 · a003c03 · a003c03
1 parent a930f6d
commit a003c03
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/...c/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HandlerService.java b/...c/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HandlerService.java
@@ -278,7 +278,6 @@ public void run() {
             }
             ProcessorWrapper processorWrapper = HandlerService.this.httpProcessorMap.get(processorKey);
             try {
-                this.preHandler();
                 if (processorWrapper.httpProcessor instanceof AsyncHttpProcessor) {
                     // set actual async request
                     HttpEventWrapper httpEventWrapper = parseHttpRequest(request);
@@ -289,10 +288,10 @@ public void run() {
                 response = processorWrapper.httpProcessor.handler(request);
 
                 if (processorWrapper.httpProcessor instanceof ShortHttpProcessor) {
-                    this.postHandler(ConnectionType.SHORT_LIVED);
+                    this.postHandlerWithTimeCostRecord(ConnectionType.SHORT_LIVED);
                     return;
                 }
-                this.postHandler(ConnectionType.PERSISTENT);
+                this.postHandlerWithTimeCostRecord(ConnectionType.PERSISTENT);
             } catch (Throwable e) {
                 exception = e;
                 // todo: according exception to generate response
@@ -301,6 +300,12 @@ public void run() {
             }
         }
 
+        private void postHandlerWithTimeCostRecord(ConnectionType type) {
+            metrics.getSummaryMetrics().recordHTTPReqResTimeCost(System.currentTimeMillis() - requestTime);
+            HTTP_LOGGER.debug("{}", response);
+            postHandler(type);
+        }
+
         private void postHandler(ConnectionType type) {
             metrics.getSummaryMetrics().recordHTTPRequest();
             HTTP_LOGGER.debug("{}", request);
@@ -315,10 +320,6 @@ private void postHandler(ConnectionType type) {
             }
         }
 
-        private void preHandler() {
-            metrics.getSummaryMetrics().recordHTTPReqResTimeCost(System.currentTimeMillis() - requestTime);
-            HTTP_LOGGER.debug("{}", response);
-        }
 
         private void error() {
             log.error(this.exception.getMessage(), this.exception);