Bugfix/new donation flow issues #1962
Conversation
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
| disabled={values.payment === DonationFormPaymentMethod.BANK} | ||
| error={Boolean(errors.finalAmount) && Boolean(submitCount > 0)} | ||
| /> | ||
| <Amount error={Boolean(errors.finalAmount) && Boolean(submitCount > 0)} /> |
There was a problem hiding this comment.
Can we please revert this change for now?
I understand the reasoning for this, but since this Amount Picker has no effect on bank transactions, in my opinion it will cause more confusion to keep it enabled.
I've already contacted the design team to look at this. If there are any changes regarding this step, lets handle them in a separate PR.
There was a problem hiding this comment.
Yes, I just reverted this one. Also reverted the change in Amount validation to not take into account the bank type payment with this commit ef26ae3
Here is a visual what I meant that the user cannot select another amount when Bank is selected and the calculation at the bottom cannot be used if the user wants to see what the fees would be.
cc @swolf86
There was a problem hiding this comment.
@nikolay-yankov
I think the transactions fees should not be displayed it should be ---- until we have the integration with paysera.
Why the amount cannot be changed, after selecting a bank transfer?
I saw that too
This reverts commit 2ceeef5.
nikolay-yankov
force-pushed
the
bugfix/new-donation-flow-issues
branch
from
ef26ae3 to
8149d2a
Compare
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
Motivation and context
Fixes several issues from ticket #1960 related to the new donation flow, discovered during QA testing.
Screenshots:
Xbutton orCancelbutton, the user remains on the same page. If the user selectsContinuebutton, then it will be redirected to the Campaign preview page.Additional change:
IMO we should not disable the
Amountfield when bank payment option is selected as this creates several side effect. IMO we should either hide it completely when Bank options is chosen or leave it always available. This is because currently, if the user selects an amount and then selects bank payment type, theAmountfield becomes disabled. This could create some confusion because the user cannot change the amount anymore and they cannot use the calculator for amount + fees at the bottom. Also if validation is triggered and the field, they cannot select an option to continue with the donation.Here I removed the option for disabling in commit 2ceeef5