Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reported new donation flow issues #1979

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

sashko9807
Copy link
Member

@sashko9807 sashko9807 commented Nov 24, 2024

Partially Closes #1960

Copy link

github-actions bot commented Nov 24, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@sashko9807 sashko9807 marked this pull request as ready for review November 24, 2024 12:48
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Nov 24, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 24, 2024
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Nov 26, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 26, 2024
@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Nov 26, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 26, 2024
Copy link
Contributor

@gparlakov gparlakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment about a console.log.

It's not a blocker for merging

@@ -173,6 +174,7 @@ export function DonationFlowForm() {

// Update the setup intent with the latest calculated amount
try {
console.log(!values.isAnonymous, session?.user, person?.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need this

@sashko9807 sashko9807 added the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 4, 2024
@sashko9807 sashko9807 merged commit f4384d8 into podkrepi-bg:master Dec 4, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donation bugs on dev env
3 participants