Support turn off NodeSourcePlugin with false option

poeschko · Jun 3, 2017 · 8fec262 · 8fec262
1 parent 1a5858a
commit 8fec262
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 45 deletions.
diff --git a/lib/node/NodeSourcePlugin.js b/lib/node/NodeSourcePlugin.js
@@ -13,6 +13,8 @@ module.exports = class NodeSourcePlugin {
 	}
 	apply(compiler) {
 		const options = this.options;
+		if(options === false) // allow single kill switch to turn off this plugin
+			return;
 
 		function getPathToModule(module, type) {
 			if(type === true || (type === undefined && nodeLibsBrowser[module])) {

diff --git a/schemas/webpackOptionsSchema.json b/schemas/webpackOptionsSchema.json
@@ -808,55 +808,64 @@
     },
     "node": {
       "description": "Include polyfills or mocks for various node stuff.",
-      "additionalProperties": {
-        "enum": [
-          false,
-          true,
-          "mock",
-          "empty"
-        ]
-      },
-      "properties": {
-        "Buffer": {
-          "enum": [
-            false,
-            true,
-            "mock"
-          ]
-        },
-        "__dirname": {
-          "enum": [
-            false,
-            true,
-            "mock"
-          ]
-        },
-        "__filename": {
-          "enum": [
-            false,
-            true,
-            "mock"
-          ]
-        },
-        "console": {
+      "anyOf": [
+        {
           "enum": [
-            false,
-            true,
-            "mock"
+            false
           ]
         },
-        "global": {
-          "type": "boolean"
-        },
-        "process": {
-          "enum": [
-            false,
-            true,
-            "mock"
-          ]
+        {
+          "additionalProperties": {
+            "enum": [
+              false,
+              true,
+              "mock",
+              "empty"
+            ]
+          },
+          "properties": {
+            "Buffer": {
+              "enum": [
+                false,
+                true,
+                "mock"
+              ]
+            },
+            "__dirname": {
+              "enum": [
+                false,
+                true,
+                "mock"
+              ]
+            },
+            "__filename": {
+              "enum": [
+                false,
+                true,
+                "mock"
+              ]
+            },
+            "console": {
+              "enum": [
+                false,
+                true,
+                "mock"
+              ]
+            },
+            "global": {
+              "type": "boolean"
+            },
+            "process": {
+              "enum": [
+                false,
+                true,
+                "mock"
+              ]
+            }
+          },
+          "type": "object"
         }
-      },
-      "type": "object"
+      ]
     },
     "output": {
       "$ref": "#/definitions/output"