Merge pull request kubernetes#99907 from liggitt/cache-test-timeout

Add test timeout to mutation detector test
pohly · Mar 7, 2021 · dc493bb · dc493bb
2 parents c37073b + 877d889
commit dc493bb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/staging/src/k8s.io/client-go/tools/cache/mutation_detector_test.go b/staging/src/k8s.io/client-go/tools/cache/mutation_detector_test.go
@@ -49,8 +49,9 @@ func TestMutationDetector(t *testing.T) {
 
 	informer := NewSharedInformer(lw, &v1.Pod{}, 1*time.Second).(*sharedIndexInformer)
 	detector := &defaultCacheMutationDetector{
-		name:   "name",
-		period: 1 * time.Second,
+		name:           "name",
+		period:         1 * time.Second,
+		retainDuration: 2 * time.Minute,
 		failureFunc: func(message string) {
 			mutationFound <- true
 		},
@@ -72,6 +73,8 @@ func TestMutationDetector(t *testing.T) {
 
 	select {
 	case <-mutationFound:
+	case <-time.After(wait.ForeverTestTimeout):
+		t.Fatalf("failed waiting for mutating detector")
 	}
 
 }