Pull request: Fix for addPostValue:forKey: of ASIFormDataRequest #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do nothing if the given key is nil - Treat the value as a blank string if the given value is nil as its string description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi pokeb,
I found that the addPostValue:forKey: method of ASIFormDataRequest is vulnerable when the given key or value is nil. Validating every arguments before passing them to this method was a bit annoying for me so I made this patch. Hope you find this useful :)
P.S. Thanks for this great boon for all iOS/Mac OS developers!