Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rewrite arithmetic operators for Expr and Series #886

Merged
merged 10 commits into from
Mar 3, 2024
Merged

feat!: rewrite arithmetic operators for Expr and Series #886

merged 10 commits into from
Mar 3, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Mar 3, 2024 •
edited
Loading

Part of #551

  • Rewrite docs
  • Rename <Series>$rem() -> <Series>$mod()
  • Add missing operators for Series
  • Other minor refactorings

@eitsupi eitsupi requested a review from etiennebacher March 3, 2024 08:53
@eitsupi eitsupi marked this pull request as ready for review March 3, 2024 09:15
@eitsupi eitsupi added this to the 0.15 milestone Mar 3, 2024
etiennebacher
etiennebacher requested changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just a couple of comments

@eitsupi
Copy link
Collaborator Author

eitsupi commented Mar 3, 2024

Thanks for your review!

@eitsupi eitsupi merged commit 1132bf6 into main Mar 3, 2024
18 checks passed
@eitsupi eitsupi deleted the s3-operator-doc branch March 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@eitsupi @etiennebacher