Improved testing and more

[cquinn]

Refactoring for testability, early error detection and reduction of Env use.

• CLI spec and parsing pulled into its own file (style from ponyup).
• Main resolves all dirs up front into FilePaths, ctx gets them for cmds.
• Bundle now gets FilePaths for bundle_dir, no more search during load.
• Bundle handles FilePath operations for all Deps
• CmdFetch now correctly handles transitive deps through actor queue.
• CmdUpdate Contraints parsing and solving extracted to new class.
• old ponyc bug workaround removed in solver.
• Setup integration harness and tests for most corral commands
• Snarfed many testdata dirs from Stable
• New logger LogNone level to turn off logging.

Fixes:

• Add tests #10: Lots of integration tests
• TODO item: Add a --path flag to allow specification of bundle dir to start in #23: Updates 'directory' to 'bundle_dir', resolves it early, and makes sure other dirs are based on it.
• TODO item: Figure out & fix layout of recursive deps #25: Ensured that fetched bundles are placed in the corral correctly.
• TODO item: Use ProcessMonitor (probably via Actions) for run command #29: Verified ProcessMonitor use is correct.
• corral fetch fails to fully fetch transitive dependencies #58: Fixed be recursion for transitive deps in CmdFetch

[SeanTAllen]

I did an initial first pass. I need to clone your repo @cquinn and take a look at the organization of the tests. It's a pure jumble of "what is going on here" when I look in the GitHub UI. I probably won't get to that until sometime Wednesday evening.

[SeanTAllen]

@cquinn was it intentional that this PR doesn't turn on integration tests being run for CI?

[cquinn]

@SeanTAllen thanks for the review. I'll push some fixes in a few minutes. I wasn't sure how to turn on integration tests for the PR, but will do that as soon as I learn.

[SeanTAllen]

@cquinn re: tests. What I suggest is the make the test command run all tests. If we need to have a make target that only does unit or integration we can add.

If you do that then all the tests will be run with the current CI setup.

The CI is now run by GitHub actions. The configuration for tests for PRs is in .github/workflows/pr.yml

[cquinn]

make unittest runs all non-integration tests in parallel.
make integration runs all integration tests, sequentially.
make test runs both of the above.

[SeanTAllen]

I think unit-test rather than unittest.

I'd say solicit other opinions before accepting mine (or just reject my opinion).

[cquinn]

FWIW: I have a followup PR (cquinn#1 for now until rebased) that builds on this one and fixes logging and -n.

[SeanTAllen]

@cquinn across most of our repos it is "unit-tests" rather than "unittest", for now, can you switch to that for the name. we don't have a standard for integration test name at this point, so I'll let you decide what it should be and we can sort out later if we want to change, but it would be good to be consistent with other Ponylang projects.

[SeanTAllen]

Other than the aforementioned change @cquinn, this looks good to merge.

[SeanTAllen]

@cquinn were these changes public facing? I think we want to remove the CHANGELOG entry as "improved testing and more" isn't really a helpful changelog entry.