Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add Payout Settlement Transaction. #12

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jayendramadaram
Copy link
Contributor

This PR is continuation of #10

Changes Made

  • Added payout-settlement Transaction builder.
  • Offers way to Schnorr Sign payout-update Transactions.
  • Added unit tests for payout-settlement struct.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (f0b35ea) to head (b1e825f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   93.13%   93.81%   +0.68%     
==========================================
  Files          13       14       +1     
  Lines        1442     1601     +159     
==========================================
+ Hits         1343     1502     +159     
  Misses         99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@pool2win pool2win left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one.

@pool2win
Copy link
Owner

@jayendramadaram - we need to rebase before we an merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants