Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make admin dashboard responsive #366

Merged
merged 6 commits into from
Jul 28, 2024

Conversation

dhruv8433
Copy link
Contributor

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

@pooranjoyb

[BUG] Make Dashboard Responsive #347

Fixes #347 (issue)

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshots and Videos:

Give screenshots and video of the changes you made

popshop-mozilla-firefox-2024-07-26-21-27-18_1QB087Fn.mp4

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2024 6:14pm

Copy link
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dhruv8433! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

check this and merge it

@pooranjoyb
Copy link
Owner

can we use the same navbar on admin dashboard too? I mean the profile icon wala button?

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

image

@dhruv8433
Copy link
Contributor Author

i added navbar that have profile icon
please inform me if you need any modifications

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please check this and tell me if you need any modifications

@pooranjoyb
Copy link
Owner

@pooranjoyb

please check this and tell me if you need any modifications

Hey @dhruv8433 see this is a bug, isn't it?

image

I guess you need to create a new Navbar Component inside the Admin directory. That should have the navigations for admin-routes

@pooranjoyb pooranjoyb added ui Improvements of User Interface level1 Issue with difficulity level 1 gssoc Girlscript Summer of Code 2024 labels Jul 27, 2024
@dhruv8433
Copy link
Contributor Author

Got it

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

I am removing sidebar and create new navbar for admin panel

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jul 27, 2024

@pooranjoyb

i updated my code and add admin navigation

image

image

image

@pooranjoyb
Copy link
Owner

image

Fix this too :/

@dhruv8433
Copy link
Contributor Author

@pooranjoyb
solved

@dhruv8433
Copy link
Contributor Author

image

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please check this and merge it

@pooranjoyb
Copy link
Owner

@pooranjoyb

please check this and merge it

Bro please add all the routes for admin :/

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

Can you please tell me what route i have to add

I think i added all sidebar routes

@pooranjoyb
Copy link
Owner

@pooranjoyb

Can you please tell me what route i have to add

I think i added all sidebar routes

I mean the transactions, orders and add products one. same, jesa navbar pe dala hua hai :/

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

check this and tell me if you need any modification
actually, i removed the sidebar and created separate navbar for the admin panel
also, make it a responsive burger menu

PopShop.Mozilla.Firefox.2024-07-27.21-09-05.online-video-cutter.com.mp4

@pooranjoyb
Copy link
Owner

Cool, ise theek kar do bss

image

@dhruv8433

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

make it full width in responsive devices

image

image

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please check this and merge it

@pooranjoyb pooranjoyb merged commit 7ccbee1 into pooranjoyb:dev Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level1 Issue with difficulity level 1 ui Improvements of User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Make Dashboard Responsive
2 participants