Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run system76-oled when Pop GNOME session is running #11

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Sep 22, 2022

This fixes flickering when using night mode and changing brightness. GNOME on Pop integrates OLED brightness with night mode, and system76-oled provides brightness control on other sessions where this is not the case.

@jackpot51 jackpot51 requested review from a team September 22, 2022 17:22
@jackpot51 jackpot51 self-assigned this Sep 22, 2022
Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Near as I can tell, this isn't breaking OLED on Pop, but does resolve screen flicker on the 15" 1080 panel for Oryp10. It isn't causing any regressions outside of that either.

@jackpot51 jackpot51 merged commit 98f778d into master Sep 27, 2022
@jackpot51
Copy link
Member Author

My next question will be how to do this same thing on Ubuntu systems that have our forked gnome-settings-daemon.

@jackpot51 jackpot51 deleted the gnome-oled branch September 27, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants